-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated macro system #344
Updated macro system #344
Conversation
@ef4 any ETA for this? Sorry for being impatient here :) But we are just closing down on a major refactoring of ember-bootstrap's build system, from having separate trees and broccoli magic to (eventually build-time) helpers (context: ember-bootstrap/ember-bootstrap#984). The initial plan was to provide our own AST transforms (much narrower scope). But having learned that these macros here also work for classic ember-cli addons, it makes these a perfect fit, and certainly a better choice than to reinvent the wheel. However I wouldn't want to be blocked for too long, that's why I'm asking! :) Just from a quick look it seems that the glimmer transforms are not updated yet, right? Maybe I can help bring this over the finish line! Could you provide me a gist of what's still missing, with any context that I might need? |
This is as far as we can go until some upstream things get fixed
Merging this because there's no need to a long-lived branch. I'll copy the remaining todo into a separate issue. |
This is bringing
@embroider/macros
up to date with RFC 507.Here's a table to track progress.