Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compat adapter's to expose shouldApplyAdapter #772

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Apr 22, 2021

The use case is that if a compat adapter is found (either the built-in ones or custom ones) they will always be used. This method allows the compat adapters to opt out if say a newer version of a package fixes the issue.

The use case is that if a compat adapter is found (either the built-in
ones or custom ones) they will always be used. This method allows the
compat adapters to opt out if say a newer version of a package fixes
the issue.
@ef4
Copy link
Contributor

ef4 commented Apr 24, 2021

Can we rename isEnabled? Because V1Addon.prototype.isEnabled looks like it controls whether the addon itself is enabled, not the compat adapter for the addon.

@thoov thoov changed the title Allow compat adapter's to expose isEnabled Allow compat adapter's to expose shouldApplyAdapter Apr 26, 2021
@thoov
Copy link
Collaborator Author

thoov commented Apr 26, 2021

@ef4 I agree, after I created the PR I did think that isEnabled isn't the best name for this. I changed it to shouldApplyAdapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants