Update app template dependency versions #790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
yarn.lock
is out-of-date and runningyarn
would update it to add0.39.1
versions of the embroider packages plus a bunch of their dependencies. I'm guessing the issue here isn't an out-of-dateyarn.lock
, but a merge oversight (?) resulting inapp-template
pointing at the0.39.1
versions rather than0.40.0
, which I think means some of the tests weren't actually running against the latest version.@embroider/shared-internals@^0.39.1
was added toyarn.lock
, I believe because it's a transitive dependency ofapp-template
'sember-auto-import
dependency. I also updated the CI scripts to runyarn
with--frozen-lockfile
soyarn.lock
being out-of-date will be caught by CI in the future.I don't really know how
scenario-tester
works with workspaces, but I'm wondering if we should changeapp-template
's@embroider/*
versions inpackage.json
to*
. Assumingscenario-tester
handles workspaces correctly, this would ensure that they always match and run against the local@embroider/*
packages, and never fetch them from the registry and run against probably-older code.If that doesn't make sense/work, then I suspect we'd want to remove
app-template
from the package workspaces and treat it as a standalone test fixture so its dependencies aren't mixed with the workspace's. As it stands, it might run against the local packages or it might run against some code fetched from the registry depending on the specifics of the different version strings, and that seems kinda non-deterministic for an automated testing environment.