Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Respect JOBS count if present #877

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

stefanpenner
Copy link
Collaborator

For web-pack:

JOBS=0 uses the current thread of execution
JOBS=1..n spawns the corresponding thread or sub-processes
No set JOBS results in a dynamically calculated number of jobs

Previously

JOBS=1 used the current thread of execution
All other variations would dynamically calculated number of jobs

Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JOBS=0 and JOBS=1 should have the same behavior (in order to match what broccoli-babel-transpiler uses)

@stefanpenner
Copy link
Collaborator Author

stefanpenner commented Jul 21, 2021

JOBS=0 and JOBS=1 should have the same behavior (in order to match what broccoli-babel-transpiler uses)

@rwjblue it's been a while now, but I believe we spoke about this after your comment, but maybe we should touch-base quick.

My thoughts, without this PR we cannot debug only 1 worker, or run the build in a single job separate of the host, without running 2 or more workers. This negative impact of this PR when compared to the positive seems acceptable, also it diverges from make -j slightly... but WDYT?

@stefanpenner stefanpenner force-pushed the respect-jobs branch 2 times, most recently from 20292a2 to e8b793f Compare July 21, 2021 19:03
@stefanpenner
Copy link
Collaborator Author

@ef4 pingaling

For web-pack:

JOBS=0 uses the current thread of execution
JOBS=1..n spawns the corresponding thread or sub-processes
No set JOBS results in a dynamically calculated number of jobs

Previously

JOBS=1 used the current thread of execution
All other variations would dynamically calculated number of jobs
@stefanpenner
Copy link
Collaborator Author

In an offline chat with @ef4 around the authoring of this PR he gave a +1. If that has changed, I will gladly revert + fix. But no need to let this linger.

@stefanpenner stefanpenner merged commit 04d39ba into master Aug 25, 2021
@stefanpenner stefanpenner deleted the respect-jobs branch August 25, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants