Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition finding the owning package of a given file when using multiple workers #881

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jun 28, 2021

PackageCache's ownerOfFile can give the wrong result when dealing with in-repo nested package structures (like a dummy app, in-repo-addon, or runtime fastboot directory) such that there is no intervening node_modules folder between the parent and child packages.

It only happens if there's a request for the parent package before the files in the child package, which is why this was a sporadic race that only happened sometimes, when running with multiple parallel workers where the order is nondeterministic.

@rwjblue rwjblue added the bug Something isn't working label Jun 29, 2021
@rwjblue rwjblue changed the title fixing packageCache race Fix race condition finding the owning package of a given file when using multiple workers Jun 29, 2021
@rwjblue rwjblue merged commit 4af550f into master Jun 29, 2021
@rwjblue rwjblue deleted the package-cache-race branch June 29, 2021 19:11
@stefanpenner
Copy link
Collaborator

woohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants