Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate @embroider/macro's babel cache when addon version's change without mutating lock file (e.g. linking) #990

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Oct 1, 2021

This ensures that using things like yarn link/npm link to test dependencies still invalidates our babel plugin's cache in most cases.

cc: @rwjblue

@rwjblue rwjblue added the bug Something isn't working label Oct 1, 2021
@rwjblue rwjblue changed the title Add cache key based on the project's addon versions Invalidate @embroider/macro's babel cache when addon version's change without mutating lock file (e.g. linking) Oct 1, 2021
@rwjblue rwjblue merged commit 9e3b199 into embroider-build:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants