-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-241] Unity: adds lun migration support #243
Conversation
8e9af49
to
fc792ba
Compare
@retryz.retry(timeout=timeout, wait=interval, on_return=False) | ||
def _do_check_move_session(move_session_id): | ||
move_session = clz.get(self._cli, _id=move_session_id) | ||
if move_session.state == enums.MoveSessionStateEnum.COMPLETED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is with FAILED
, CANCELLED
or COMPLETED
, it is completed too. We could return quickly here, or we need to wait until timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, will check FAILED and CANCELLED states.
Could you fix the pep8 failure in another PR? |
Update the README.rst about the Unity migration. |
is_compressed = self.is_data_reduction_enabled | ||
|
||
try: | ||
move_session = clz.create(self._cli, self, dest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the lun is in cg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If lun in cg, REST will return 409 source or dest does not exist error, storops will raise UnityMigrationSourceDestNotExistsError exception.
#245 is opened to fix pep8 issues. |
fc792ba
to
9d05e94
Compare
Done. |
Use move session to implement lun migration.
9d05e94
to
5ac41e1
Compare
Features: - Unity: Adds lun migration support (#241) (#243) - Unity: Support share shrink in Storops (#255) - Unity: Add exceptions for input shrink share size (#258) - Unity: Add replication support (#256) Fixed bugs: - Update pytest version which is required 3.6.0 - Fix appveyor failure on pip 19.0.0/1 (#257)
Features: - Unity: Adds lun migration support (#241) (#243) - Unity: Support share shrink in Storops (#255) - Unity: Add exceptions for input shrink share size (#258) - Unity: Add replication support (#256) Fixed bugs: - Update pytest version which is required 3.6.0 - Fix appveyor failure on pip 19.0.0/1 (#257)
Use move session to implement lun migration.