[GH-241] Unity: adds lun migration support #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yong-huang
force-pushed
the
unity_lun_migration
branch
from
8e9af49
to
fc792ba
Compare
| @retryz.retry(timeout=timeout, wait=interval, on_return=False) | ||
| def _do_check_move_session(move_session_id): | ||
| move_session = clz.get(self._cli, _id=move_session_id) | ||
| if move_session.state == enums.MoveSessionStateEnum.COMPLETED: |
There was a problem hiding this comment.
If it is with FAILED, CANCELLED or COMPLETED, it is completed too. We could return quickly here, or we need to wait until timeout.
There was a problem hiding this comment.
Fixed, will check FAILED and CANCELLED states.
|
Could you fix the pep8 failure in another PR? |
|
Update the README.rst about the Unity migration. |
| is_compressed = self.is_data_reduction_enabled | ||
|
|
||
| try: | ||
| move_session = clz.create(self._cli, self, dest, |
There was a problem hiding this comment.
What if the lun is in cg?
There was a problem hiding this comment.
If lun in cg, REST will return 409 source or dest does not exist error, storops will raise UnityMigrationSourceDestNotExistsError exception.
#245 is opened to fix pep8 issues. |
yong-huang
force-pushed
the
unity_lun_migration
branch
from
fc792ba
to
9d05e94
Compare
Done. |
Use move session to implement lun migration.
yong-huang
force-pushed
the
unity_lun_migration
branch
from
9d05e94
to
5ac41e1
Compare
Murray-LIANG
added a commit
that referenced
this pull request
Feb 11, 2019
Features: - Unity: Adds lun migration support (#241) (#243) - Unity: Support share shrink in Storops (#255) - Unity: Add exceptions for input shrink share size (#258) - Unity: Add replication support (#256) Fixed bugs: - Update pytest version which is required 3.6.0 - Fix appveyor failure on pip 19.0.0/1 (#257)
Murray-LIANG
added a commit
that referenced
this pull request
Feb 11, 2019
Features: - Unity: Adds lun migration support (#241) (#243) - Unity: Support share shrink in Storops (#255) - Unity: Add exceptions for input shrink share size (#258) - Unity: Add replication support (#256) Fixed bugs: - Update pytest version which is required 3.6.0 - Fix appveyor failure on pip 19.0.0/1 (#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use move session to implement lun migration.