Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #249 to issue #248 is too open. It changed
if resp.status_code == 401:
toif resp.status_code >= 400 and resp.status_code != 404:
, which meansstatus code like 422 (hlu number conflict) raise
HttpClientError
andthe
HttpClientError
cannot be caught afterward and exceptions toCinder. Thus the retry mechanism doesn't take effect.
Another example is that deleting a volume twice. The second would return
409, and
HttpClientError
is raised directly to Cinder. The expectedbehavior should be that
ResourceNotFound
is caught and ignored byUnity driver.