Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Unity quota management #344

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Support for Unity quota management #344

merged 3 commits into from
Apr 29, 2021

Conversation

rajendraindukuri
Copy link
Contributor

This PR covers support for Unity Quota management:

  1. CRUD operations (whichever supported by API) for userQuota, treeQuota ,quotaConfig components
  2. Unit test coverage for the same

@codecov
Copy link

codecov bot commented Apr 22, 2021 •
edited
Loading

Codecov Report

Merging #344 (790c23b) into master (7254045) will increase coverage by 0.08%.
The diff coverage is 99.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   91.77%   91.86%   +0.08%     
==========================================
  Files         100      103       +3     
  Lines       14002    14140     +138     
  Branches     1699     1710      +11     
==========================================
+ Hits        12851    12990     +139     
+ Misses        740      739       -1     
  Partials      411      411
Impacted Files Coverage Δ
storops/unity/resource/user_quota.py 97.77% <97.77%> (ø)
storops/exception.py 97.45% <100.00%> (+<0.01%) ⬆️
storops/unity/enums.py 98.84% <100.00%> (+<0.01%) ⬆️
storops/unity/resource/quota_config.py 100.00% <100.00%> (ø)
storops/unity/resource/system.py 95.31% <100.00%> (+0.23%) ⬆️
storops/unity/resource/tree_quota.py 100.00% <100.00%> (ø)
storops/lib/common.py 93.13% <0.00%> (-0.27%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7254045...790c23b. Read the comment docs.

@rajendraindukuri rajendraindukuri force-pushed the unity-support-for-quota-management branch from 86dd8a7 to c5d36bd Compare April 22, 2021 13:21
yong-huang
yong-huang requested changes Apr 23, 2021
View reviewed changes
storops/unity/parser_configs.yaml Show resolved Hide resolved
storops/unity/parser_configs.yaml Show resolved Hide resolved
storops/unity/parser_configs.yaml Show resolved Hide resolved
storops/unity/resource/system.py Outdated Show resolved Hide resolved
storops/unity/resource/tree_quota.py Outdated Show resolved Hide resolved
storops_test/unity/resource/test_system.py Outdated Show resolved Hide resolved
storops_test/unity/resource/test_system.py Outdated Show resolved Hide resolved
storops_test/unity/resource/test_system.py Outdated Show resolved Hide resolved
storops_test/unity/resource/test_system.py Outdated Show resolved Hide resolved
storops_test/unity/resource/test_system.py Outdated Show resolved Hide resolved
@yong-huang yong-huang merged commit 5bac468 into emc-openstack:master Apr 29, 2021
yong-huang added a commit that referenced this pull request Apr 30, 2021
@yong-huang
Release 1.2.9
cedad6a 
- 5bac468 Support for Unity quota management (#344)
- 7254045 Unity: support of HTTP header Application-Type (#341)
- e729361 VNX: support to specify SP in SMP creation (#336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-huang yong-huang yong-huang approved these changes

@wangi1 wangi1 Awaiting requested review from wangi1

@Y0NG-WANG Y0NG-WANG Awaiting requested review from Y0NG-WANG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajendraindukuri @yong-huang