Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ws library to gobwasws for better deps #78

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Change ws library to gobwasws for better deps #78

merged 2 commits into from
Apr 15, 2023

Conversation

emcfarlane
Copy link
Owner

Closes #75

@emcfarlane emcfarlane self-assigned this Apr 15, 2023
@emcfarlane emcfarlane merged commit 4fbc95c into main Apr 15, 2023
@emcfarlane emcfarlane deleted the gobwasws branch April 15, 2023 14:02
@prochac
Copy link

prochac commented Aug 8, 2023

I have tried to check out your 39bcf5e version and endup just with this go.mod file:
So the switch wasn't necesery.

module larking.io

go 1.20

require (
	github.com/google/go-cmp v0.5.9
	golang.org/x/net v0.9.0
	golang.org/x/sync v0.1.0
	google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1
	google.golang.org/grpc v1.54.0
	google.golang.org/protobuf v1.30.0
	nhooyr.io/websocket v1.8.7
)

require (
	github.com/golang/protobuf v1.5.3 // indirect
	github.com/klauspost/compress v1.10.3 // indirect
	golang.org/x/sys v0.7.0 // indirect
	golang.org/x/text v0.9.0 // indirect
)

@emcfarlane
Copy link
Owner Author

@prochac thanks, sorry I missed that. Was it from running go mod tidy?

@prochac
Copy link

prochac commented Aug 9, 2023

@prochac thanks, sorry I missed that. Was it from running go mod tidy?

Not really, I removed all indirect deps manually, including go.sum content and let go mod tidy to resolve the dep tree again.
It's possible that the indirect deps are being kept, but since Go 1.17 they not being added*
See https://go.dev/doc/go1.17#graph-pruning

But take it just as my guess 😬

*) Those that aren't really used. They are mentioned in go.sum tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Gin dep
2 participants