Skip to content

Commit

Permalink
Improve text
Browse files Browse the repository at this point in the history
Co-authored-by: AdrianSosic <adrian.sosic@merckgroup.com>
  • Loading branch information
Scienfitz and AdrianSosic committed Aug 28, 2024
1 parent 3195053 commit f9c16b9
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
`DiscreteNoLabelDuplicatesConstraint`
- Discrete search space Cartesian product can be created lazily via Polars
- `recommend` now accepts the `pending_measurements` argument, informing the algorithm
that these points were already selected for evaluation
about points that were already selected for evaluation

### Changed
- Passing an `Objective` to `Campaign` is now optional
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ Besides functionality to perform a typical recommend-measure loop, BayBE's highl
- 🎭 Hybrid (mixed continuous and discrete) spaces
- 🚀 Transfer learning: Mix data from multiple campaigns and accelerate optimization
- 🌎 Distributed workflows: Run campaigns asynchronously with pending measurements
- 🎓 Active Learning: Perform smart data acquisition campaigns
- 🎓 Active learning: Perform smart data acquisition campaigns

- ⚙️ Custom surrogate models: For specialized problems
- 📈 Comprehensive backtest, simulation and imputation utilities: Benchmark and find your best settings
- 📝 Fully typed and hypothesis-tested: Robust code base
Expand Down
5 changes: 2 additions & 3 deletions baybe/acquisition/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,8 @@ def to_botorch(
additional_params["X_pending"] = to_tensor(pending_x)
else:
raise IncompatibleAcquisitionFunctionError(
f"Non-empty pending measurements were provided, but the "
f"chosen acquisition function {self.__class__.__name__} does not "
f"support this."
f"Pending measurements were provided but the chosen acquisition "
f"function '{self.__class__.__name__}' does not support this."
)

params_dict.update(additional_params)
Expand Down
6 changes: 3 additions & 3 deletions baybe/recommenders/naive.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ def recommend( # noqa: D102
# We are in a hybrid setting now
if pending_measurements is not None:
raise UnusedObjectWarning(
f"A non-empty set of pending measurements was provided, but the "
f"selected recommender {self.__class__.__name__} with discrete "
f"sub-recommender {self.disc_recommender.__class__.__name__} only "
f"Pending measurements were provided but the selected recommender "
f"'{self.__class__.__name__}' with discrete "
f"sub-recommender '{self.disc_recommender.__class__.__name__}' only "
f"utilizes this information for purely discrete spaces."
)

Expand Down
6 changes: 3 additions & 3 deletions baybe/recommenders/pure/nonpredictive/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ def recommend( # noqa: D102
and searchspace.type is not SearchSpaceType.DISCRETE
):
raise UnusedObjectWarning(
f"A non-empty set of pending measurements was provided, but the "
f"selected recommender {self.__class__.__name__} only utilizes this "
f"information for purely discrete spaces."
f"Pending measurements were provided but the selected recommender "
f"'{self.__class__.__name__}' only utilizes this information for "
f"purely discrete spaces."
)
return super().recommend(
batch_size=batch_size,
Expand Down

0 comments on commit f9c16b9

Please sign in to comment.