-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy loading torch - part 1 #119
Conversation
bd9ae99
to
4a29f1b
Compare
cabfb8e
to
7b4bfad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rjavadi, thanks for the PR and please apologize that no one of us responded last week. Martin was OOO + Alex and I were fighting to get the new 0.7.3 released.
I've added some in-line comments below. Apart from that, here some general feedback:
- Your branch was again ab bit messe (~40 commits) so I rebased it and created a backup of the original version. Since your changes are pretty much orthogonal to what is currently happening in the repo, it would be really nice if you could try to rebase instead of merge (see also our new contributing guideline). Let me know if you have questions 🙃
- Also, have a look at the general style the of the existing commits and changelog messages
- Finally, to better organize our branches, it would be nice if you could place your next branch into an appropriate "folder". For the current PR, you could have used e.g. "refactor/torch_imports" or similar 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing more to add, so I'll already approve :)
@rjavadi what is the status of this PR? I must admit I cant really follow, could you add comments in threads if youve addressed them and/or have questions/suggestions? Also, what has happened to the commit history? |
It's ready to merge. I marked the conversations as resolved. I fixed the history. |
00485c2
to
c4f1920
Compare
@rjavadi first of all, thanks for your contribution :) I've seen that the tests currently fail, could maybe investigate the following? |
I fixed branch history and rebased latest updates on main branch. I'm dismissing this review because it appears as a "change request" and prevents merging.
1295ae3
to
2266102
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @rjavadi :)
This is the first part of optimizing torch imports.
All tests passed on my machine with python 3.10 and 3.11.