-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Python 3.12 #153
Enable Python 3.12 #153
Conversation
The copy needs to made *after* all hooks are registered
a7fc1da
to
ad6fed5
Compare
Hi @Scienfitz, it took me one afternoon of debugging, but I eventually found the issue. Turned out it has nothing to do with Regarding this PR: I made another minor change, which happens to fix the symptoms of the bug (for the root cause, we'll have to see what will happen in the ticket). The problem is fixed because the validation converter now contains an explicit hook for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged but the required pipeline checks still need to be adjusted.
Solves #156 |
(Written by Adrian) Enables Python 3.12 and fixes a bug with the validation converter, which also happens to fix the
cattrs
issue that originally blocked this PR (see details in PR comment).