Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python syntax upgrade #176

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Python syntax upgrade #176

merged 3 commits into from
Mar 25, 2024

Conversation

AdrianSosic
Copy link
Collaborator

@AdrianSosic AdrianSosic commented Mar 20, 2024

Update the syntax to Python 3.9 via pyupgrade and add pyupgrade as a pre-commit hook.

@AdrianSosic AdrianSosic added the repo Requires changes to the project configuration label Mar 20, 2024
@AdrianSosic AdrianSosic self-assigned this Mar 20, 2024
Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a quick look and saw that there are a lot of changes. It would be greate if you could elaborate in some more detail on the changes that you implemented here, ideally in the PR description and what the focus of the reviews should be.

.pre-commit-config.yaml Show resolved Hide resolved
The `--keep-runtime-typing` flag is used to avoid switching to the new union syntax (which exists only in py310 and above) in files with enabled future annotations.
... by running `pre-commit run --all-files`
@Scienfitz Scienfitz merged commit 10d1372 into main Mar 25, 2024
10 checks passed
@Scienfitz Scienfitz deleted the repo/pyupgrade branch March 25, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Requires changes to the project configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants