Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tox-uv #182

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Use tox-uv #182

merged 2 commits into from
Apr 22, 2024

Conversation

AdrianSosic
Copy link
Collaborator

@AdrianSosic AdrianSosic commented Mar 26, 2024

Speedup our environment creation by using uv instead of pip via tox-uv.

The following times were obtained on my local machine by creating environments via tox --devenv toxenv -e audit-py39 (since audit installs all dev dependencies):

  • tox: 64s
  • tox-uv (no cache): 29s
  • tox-uv (cached): 4s

@AdrianSosic AdrianSosic added the repo Requires changes to the project configuration label Mar 26, 2024
@AdrianSosic AdrianSosic self-assigned this Mar 26, 2024
@AdrianSosic AdrianSosic changed the title Use tox-uv in pipelines Use tox-uv Mar 26, 2024
@AdrianSosic
Copy link
Collaborator Author

@Scienfitz @AVHopp
Next to the local speedups, we do also get very decent speedups in the CI, see screenshots below. However, as you can see, one of the tests failed because of a timeout that can occur in CI with large dependencies such as torch. There is already an open issue (astral-sh/uv#1921).

What do we do? Manually adjust or (my preference:) just keep the PR up until they fixed the issue (which probably happens very soon) and only merge once our pipeline is stable with the default settings?

With tox:
image

With tox-uv:
image

CHANGELOG.md Show resolved Hide resolved
@Scienfitz Scienfitz added the on hold PR progress is awaiting for something else to continue label Apr 3, 2024
@AdrianSosic AdrianSosic removed the on hold PR progress is awaiting for something else to continue label Apr 22, 2024
@AdrianSosic AdrianSosic merged commit 725dca5 into main Apr 22, 2024
19 checks passed
@AdrianSosic AdrianSosic deleted the repo/tox-uv branch April 22, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Requires changes to the project configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants