Include custom `ScaleKernel` #221

AVHopp · 2024-04-26T13:26:35Z

This PR introduces custom ScaleKernels. It is currently based on #219 and will be properly rebased and moved out of draft state once that PR is merged.

AVHopp · 2024-04-29T14:43:58Z

@Scienfitz @AdrianSosic just a quick ping that the ScaleKernel PR is ready for review and already includes the new location for the lengthscale_prior field as we discussed :)

AdrianSosic

Hi @AVHopp, here the first batch of comments

baybe/kernels/__init__.py

baybe/kernels/base.py

baybe/kernels/basic.py

tests/hypothesis_strategies/kernels.py

baybe/kernels/basic.py

tests/serialization/test_kernel_serialization.py

baybe/kernels/base.py

baybe/surrogates/gaussian_process.py

baybe/kernels/basic.py

tests/hypothesis_strategies/kernels.py

tests/test_iterations.py

baybe/utils/basic.py

The `filter_attributes` approach is going to be replaced in an upcoming PR anyway.

AdrianSosic

I think everything's ready for merge from my side now 🚀

AVHopp added the enhancement Expand / change existing functionality label Apr 26, 2024

AVHopp self-assigned this Apr 26, 2024

AVHopp force-pushed the feature/scale_kernel branch from 236aed5 to 78695ae Compare April 29, 2024 14:42

AVHopp marked this pull request as ready for review April 29, 2024 14:43

AVHopp requested review from Scienfitz and AdrianSosic as code owners April 29, 2024 14:43

AdrianSosic requested changes Apr 29, 2024

View reviewed changes

AdrianSosic reviewed Apr 29, 2024

View reviewed changes

baybe/kernels/basic.py Outdated Show resolved Hide resolved

Scienfitz reviewed May 3, 2024

View reviewed changes

tests/serialization/test_kernel_serialization.py Show resolved Hide resolved

Scienfitz reviewed May 3, 2024

View reviewed changes

baybe/kernels/base.py Outdated Show resolved Hide resolved

baybe/kernels/base.py Outdated Show resolved Hide resolved

baybe/surrogates/gaussian_process.py Outdated Show resolved Hide resolved

AVHopp force-pushed the feature/scale_kernel branch 2 times, most recently from 7862ab3 to ba2e41e Compare May 6, 2024 15:03

Scienfitz reviewed May 6, 2024

View reviewed changes

baybe/kernels/basic.py Outdated Show resolved Hide resolved

baybe/kernels/basic.py Outdated Show resolved Hide resolved

AVHopp added 16 commits May 7, 2024 08:05

Add custom scale kernels and adjust base class to make them usable

f159556

Use custom scale kernels in Gaussian Processes

04103c3

Add more detailed strategies for kernels

b9bcf9d

Include new kernel strategies in tests

12a80f1

Move lengthscale_prior field to MaternKernel

296e845

Update CHANGELOG.md

a7ed2f7

Reformat for consistency reasons

4838058

Fix docstring of outputscale_prior

d9067d7

Simplify selection of base_kernels

aa88eec

Fix typo in docstring

df66419

Remove unnecessary comments

1a5bd77

Remove default selection of kernel in ScaleKernel

d8b6475

Remove kw_only argument from outputscale prior

c6a96a8

Use fields of gpytorch Kernel class when constructing kernels

12315c0

Add utility for finding parent classes

101b1e6

Use new parent-finding functionality in to_gpytorch

da81938

AVHopp added 3 commits May 8, 2024 12:28

Rename get_parent_classes to get_base_classes

dec4eca

Change value of include_class default argument in get_base_classes

a4c49cf

Reintroduce option of not having a lengthscale_prior

77d662d

AVHopp commented May 8, 2024

View reviewed changes

tests/hypothesis_strategies/kernels.py Outdated Show resolved Hide resolved

AVHopp and others added 8 commits May 8, 2024 12:42

Fix names of attributes in hypothesis test

d2e2a72

Fix function name

82af917

Make scale_kernel strategy composite based

22b0bab

Compactify changelog entry

1fc6984

Fix docstrings

43efba2

Remove unnecessary tensor dimension

978a8d5

Add validators for Kernel attributes

75e6180

Move fraction converter to new conversion.py module

1a9a2a0

AdrianSosic requested changes May 13, 2024

View reviewed changes

tests/test_iterations.py Outdated Show resolved Hide resolved

baybe/utils/basic.py Outdated Show resolved Hide resolved

AdrianSosic added 2 commits May 13, 2024 10:48

Fix kernel strategies

97bb031

Ignore mypy warning

b34529c

The `filter_attributes` approach is going to be replaced in an upcoming PR anyway.

AdrianSosic force-pushed the feature/scale_kernel branch from 36897c7 to b34529c Compare May 13, 2024 08:49

AVHopp added 2 commits May 13, 2024 18:09

Remove restrictions on kernel tests

1772573

Rework get_base_classes

89b565f

AdrianSosic force-pushed the feature/scale_kernel branch from f151de1 to 89b565f Compare May 13, 2024 16:10

AdrianSosic approved these changes May 13, 2024

View reviewed changes

Another rework of the base class utility

bcab06a

AVHopp force-pushed the feature/scale_kernel branch from 43c076c to bcab06a Compare May 14, 2024 06:42

Set initial lengthscale in kernel base class

ce6590c

AdrianSosic force-pushed the feature/scale_kernel branch from a88a533 to ce6590c Compare May 14, 2024 08:28

AdrianSosic added 2 commits May 14, 2024 13:18

Use walrus operator in ScaleKernel

1f75107

Fix bug in signature matching logic

2124ac2

Scienfitz approved these changes May 14, 2024

View reviewed changes

Remove no longer needed mypy ignore

80ae210

AdrianSosic merged commit 09243ce into main May 14, 2024
10 checks passed

AdrianSosic deleted the feature/scale_kernel branch May 14, 2024 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include custom `ScaleKernel` #221

Include custom `ScaleKernel` #221

AVHopp commented Apr 26, 2024

AVHopp commented Apr 29, 2024

AdrianSosic left a comment

AdrianSosic left a comment

Include custom ScaleKernel #221

Include custom ScaleKernel #221

Conversation

AVHopp commented Apr 26, 2024

AVHopp commented Apr 29, 2024

AdrianSosic left a comment

Choose a reason for hiding this comment

AdrianSosic left a comment

Choose a reason for hiding this comment

Include custom `ScaleKernel` #221

Include custom `ScaleKernel` #221