Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surrogate slots #251

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix surrogate slots #251

merged 2 commits into from
May 28, 2024

Conversation

Scienfitz
Copy link
Collaborator

@Scienfitz Scienfitz commented May 28, 2024

Non GP surrogate models could experience problems with deepcopy and the simulation module because they were non-slotted but the base class was slotted. This removes the base class slots.

@Scienfitz Scienfitz self-assigned this May 28, 2024
@Scienfitz Scienfitz added the bug Something isn't working label May 28, 2024
@Scienfitz Scienfitz merged commit d57e1c8 into main May 28, 2024
9 of 10 checks passed
@Scienfitz Scienfitz deleted the fix/slotted_surrogate branch May 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants