Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign validators #262

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Campaign validators #262

merged 6 commits into from
Jun 13, 2024

Conversation

AdrianSosic
Copy link
Collaborator

@AdrianSosic AdrianSosic commented Jun 5, 2024

This PR adds the missing validators to the Campaign attributes and freezes the searchspace/objective attributes.

@AdrianSosic AdrianSosic added the enhancement Expand / change existing functionality label Jun 5, 2024
@AdrianSosic AdrianSosic self-assigned this Jun 5, 2024
baybe/campaign.py Outdated Show resolved Hide resolved
This reverts commit c6ac0d6.

The decision if attributes need to be frozen will be postponed until
the corresponding validation checks are in place (e.g. adding
measurements with columns that have no parameter/target match)
@AdrianSosic AdrianSosic force-pushed the feature/campaign_validators branch from 8b78eed to be9dcda Compare June 13, 2024 07:53
@AdrianSosic AdrianSosic force-pushed the feature/campaign_validators branch from 7e13766 to b7cc634 Compare June 13, 2024 09:04
@AdrianSosic AdrianSosic merged commit 92e445f into main Jun 13, 2024
10 checks passed
@AdrianSosic AdrianSosic deleted the feature/campaign_validators branch June 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Expand / change existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants