Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register hook with the same signature #275

Merged
merged 12 commits into from
Jun 20, 2024

Conversation

RimRihana
Copy link
Contributor

@RimRihana RimRihana commented Jun 19, 2024

This PR implements the first version of the register_hook utility with a simple example.

Please note: no big reviewing effort is required since these changes were already approved on #247 .

@RimRihana RimRihana self-assigned this Jun 19, 2024
@AVHopp
Copy link
Collaborator

AVHopp commented Jun 20, 2024

As confirmation: I manually verified that the current content of the PR is 100% identical to the state of the original "big PR" up to and including commit d39978b.

Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you all already reviewed this code and since I see no need for changes, I'm more than happy to also approve here.

@AdrianSosic AdrianSosic force-pushed the register_hook_with_the_same_signature branch from 0ac3708 to 748c847 Compare June 20, 2024 08:06
@AdrianSosic AdrianSosic marked this pull request as draft June 20, 2024 08:10
@AdrianSosic AdrianSosic marked this pull request as ready for review June 20, 2024 08:10
@AdrianSosic AdrianSosic force-pushed the register_hook_with_the_same_signature branch from 748c847 to 8348cc5 Compare June 20, 2024 08:11
@AdrianSosic AdrianSosic merged commit ec077ac into dev_register_hooks Jun 20, 2024
1 check passed
@AdrianSosic AdrianSosic deleted the register_hook_with_the_same_signature branch June 20, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants