-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register hook with the same signature #275
Register hook with the same signature #275
Conversation
As confirmation: I manually verified that the current content of the PR is 100% identical to the state of the original "big PR" up to and including commit d39978b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you all already reviewed this code and since I see no need for changes, I'm more than happy to also approve here.
0ac3708
to
748c847
Compare
748c847
to
8348cc5
Compare
This PR implements the first version of the
register_hook
utility with a simple example.Please note: no big reviewing effort is required since these changes were already approved on #247 .