Replace is_numeric class attribute with is_numerical
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scienfitz
approved these changes
Jun 26, 2024
AdrianSosic
force-pushed
the
refactor/is_numeric
branch
from
3fd5168 to
f8a5bf4
Compare
`classproperty` still causes problems with the docs, and in this case the property would need to be public in order to implement the deprecation
AdrianSosic
changed the title
is_numeric class attributeis_numeric class attribute with is_numerical
Scienfitz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For naming consistency,
is_numericgets replaced withis_numerical.