Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate caching in fulltest pipeline #294

Closed
wants to merge 1 commit into from
Closed

Deactivate caching in fulltest pipeline #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# NOTES:
# - The map syntax used for matrix is flagged red but actually works
# - This runs everything in Python 3.12, except the fulltest which is also run in 3.10
# - Only coretest and fulltest environments are cached due to space limit

name: Continuous Integration
on:
Expand Down Expand Up @@ -155,10 +154,6 @@ jobs:
id: setup-python
with:
python-version: ${{ matrix.py-version.semantic }}
- uses: actions/cache@v4
with:
path: .tox/fulltest-${{ matrix.py-version.tox }}
key: fulltest-${{ matrix.py-version.tox }}-${{ hashFiles('pyproject.toml') }}-${{ hashFiles('tox.ini') }}
- name: Run full tests
run: |
pip install tox-uv
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/regular.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# NOTES:
# - The map syntax used for matrix is flagged red but actually works
# - This runs everything in Python 3.10, 3.11 and 3.12
# - No environments are cached due to space limit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old reason is in principle still true so why delete?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's not the primary reason why we don't want caching here, right? I thought we explicitly want to trigger to full installation pipeline etc (including newest package versions etc) in order to have a true e2e test? While the old reason might still be valid, it doesn't matter here. Or how would you even want me to express that? I guess not like "... to perform a full end-to-end test. Even if we didn't care about e2e, environments would still not be cached due to space limits." 😄

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it was certainly one of the reasons and still is, if this action creates lots of caches it might delete caches form CI because theres a limit, just keep it and add your reason, no reason to delete

# - Environments are **not** cached in order to perform a full end-to-end test

name: Regular Checks
on:
Expand Down
Loading