Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iteration test retries #374

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Add iteration test retries #374

merged 8 commits into from
Sep 9, 2024

Conversation

Scienfitz
Copy link
Collaborator

@Scienfitz Scienfitz commented Sep 7, 2024 •
edited
Loading

An attempt to reduce pipelines failures due to numerics

  • uses tenacity to retry the iteration test when a known numerical exception is thrown
  • adds temporary random seed to iteration tests to provide more numerical variance
  • enforces integer size limits in baybe random seed utilities

@Scienfitz Scienfitz added the enhancement Expand / change existing functionality label Sep 7, 2024
@Scienfitz Scienfitz self-assigned this Sep 7, 2024
@Scienfitz Scienfitz force-pushed the feature/retry_numerical_test_failures branch from 4ce38a3 to e3787e7 Compare September 7, 2024 19:35
@Scienfitz Scienfitz marked this pull request as ready for review September 8, 2024 21:41
AVHopp
AVHopp reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the tests with the naive hybrid recommender suddenly fail?

.lockfiles/py310-dev.lock Show resolved Hide resolved
@Scienfitz Scienfitz force-pushed the feature/retry_numerical_test_failures branch from 0227241 to 3faa26a Compare September 9, 2024 11:24
@Scienfitz Scienfitz force-pushed the feature/retry_numerical_test_failures branch from 3faa26a to 7736e53 Compare September 9, 2024 11:26
@Scienfitz Scienfitz force-pushed the feature/retry_numerical_test_failures branch from cc6ab11 to d6648a4 Compare September 9, 2024 13:52
@Scienfitz Scienfitz merged commit 8e40acf into main Sep 9, 2024
10 of 11 checks passed
@Scienfitz Scienfitz deleted the feature/retry_numerical_test_failures branch September 9, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVHopp AVHopp AVHopp left review comments

@AdrianSosic AdrianSosic Awaiting requested review from AdrianSosic AdrianSosic is a code owner

Assignees

@Scienfitz Scienfitz

Labels
enhancement Expand / change existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scienfitz @AVHopp