Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Name Matching for Retrieving Comp Rep Indices #379

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix Name Matching for Retrieving Comp Rep Indices #379

merged 2 commits into from
Sep 24, 2024

Conversation

Scienfitz
Copy link
Collaborator

Fixes #352

Now

  • retrieves the parameter object belonging to the requested name
  • then exact-matches column names in the comp_rep to the ones of the parameter via its comp_rep_columns

@Scienfitz Scienfitz added the bug Something isn't working label Sep 10, 2024
@Scienfitz Scienfitz self-assigned this Sep 10, 2024
@Scienfitz Scienfitz mentioned this pull request Sep 10, 2024
Closed
@Scienfitz Scienfitz force-pushed the fix/get_comp_rep_parameter_indices branch from 38072e5 to 89cb3d7 Compare September 10, 2024 13:20
@Scienfitz Scienfitz force-pushed the fix/get_comp_rep_parameter_indices branch from 89cb3d7 to 9ccded4 Compare September 22, 2024 17:22
@Scienfitz
Copy link
Collaborator Author

@AVHopp 21 line PR awaiting review

AVHopp
AVHopp approved these changes Sep 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Scienfitz Scienfitz force-pushed the fix/get_comp_rep_parameter_indices branch from 9ccded4 to 06e8ae4 Compare September 24, 2024 14:02
@Scienfitz Scienfitz force-pushed the fix/get_comp_rep_parameter_indices branch from 06e8ae4 to 0c82a58 Compare September 24, 2024 14:25
@Scienfitz Scienfitz merged commit 02ad6e2 into main Sep 24, 2024
10 of 11 checks passed
@Scienfitz Scienfitz deleted the fix/get_comp_rep_parameter_indices branch September 24, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVHopp AVHopp AVHopp approved these changes

@AdrianSosic AdrianSosic Awaiting requested review from AdrianSosic AdrianSosic is a code owner

Assignees

@Scienfitz Scienfitz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of SearchSpace.get_comp_rep_parameter_indices
2 participants
@Scienfitz @AVHopp