Speedup Bernoulli Multi-Armed Bandit Example #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianStreibel
requested review from
Scienfitz,
AdrianSosic and
AVHopp
as code owners
julianStreibel
changed the title
Scienfitz
requested changes
Sep 11, 2024
Co-authored-by: Martin Fitzner <17951239+Scienfitz@users.noreply.github.com>
Scienfitz
requested changes
Sep 11, 2024
Scienfitz
approved these changes
Sep 11, 2024
|
you should also be aware that this PR will only change the state of the |
AVHopp
approved these changes
Sep 16, 2024
julianStreibel
force-pushed
the
fix/fast_moke_test_mab_example
branch
from
f11c754 to
b49841a
Compare
|
@julianStreibel merging now, many thx for the future: please dont merge from a fork unless its explicitly useful to fork (like when working on actions or docs etc). You are added as a collaborator and should be able to make branches etc here in origin, it makes working together a bit easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the runtime of the Bernoulli multi-armed bandit example from about 55 seconds to 7 seconds (in SMOKE_TEST setting) and sets a random seed for reproducibility.
This is supposed to improve the displayed results in the example which were unconverged and didnt show the discussed trend.