start on negative valence update #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core PV DA method at start in ApplyPVLV.. CS da updates online. VSPatch learns from prev senders.
…al vars so results accessible from GPU). added gain factors, etc.
…overall -- add a SetNUSs method
etuleu
reviewed
Aug 28, 2023
|
Still a work in progress - should be working soon - can go over on weds |
…PU / GPU; clip DA GGain in NeuroMod so it doesn't get negative (fixes FloatFromInt errors finally!); other cleanup. Now actually minimally working in PVLV.
…erall flags, and PVLV uses them at next trial start to update maxes etc.
…in pvlv looks reasonable.
… drive ACh and gating (need to test); don't use vspatch from a prior reward trial (fixes give up in boa). still need to figure out timing of lhb dip sum vs. pvda etc.
…ing for HasRew even if negative! that almost certainly affected give up. need better testing.
…dded Time in addition to Effort; minimally working but params need adjusting
…nd needs urgency but it isn't quite working right.
This was referenced Sep 5, 2023
…erences via GiBase, and RLRate uses Sigmoid to prevent saturation, SpkPrv based only on GeIntNorm
…offsets right -- now pvlv NegAcq working again..
…n the Makefile -- all updated now
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 29.88% 29.45% -0.44%
==========================================
Files 85 90 +5
Lines 15524 16003 +479
==========================================
+ Hits 4639 4713 +74
- Misses 10623 11016 +393
- Partials 262 274 +12
☔ View full report in Codecov by Sentry. |
|
@etuleu this is ready to try out on obelisk boa etc -- more testing to be done but should be good enough to start exploring. |
…s whether it can build; added build_exe target that makes the exe, and remake them for params_good to be sure; updated VSPatch param defaults to match, removing spurious diffs
etuleu
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@etuleu here's a start on what we sketched out..