Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResponseParser Failed - Which upstream? #187

Open
MysticRyuujin opened this issue Oct 4, 2022 · 1 comment
Open

ResponseParser Failed - Which upstream? #187

MysticRyuujin opened this issue Oct 4, 2022 · 1 comment
Milestone
Version 0.14

Comments

@MysticRyuujin
Copy link
Contributor

Feature Request

I upgraded to the latest version and I started seeing this:

2022-04-10 15:04:41.691 | WARN  |       ResponseParser | Failed to parse JSON from upstream: Unrecognized token 'Request': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (byte[])"Request Blocked. Contact Flux Team."; line: 1, column: 9]
2022-04-10 15:04:41.702 | WARN  |       ResponseParser | Failed to parse JSON from upstream: Unexpected character ('<' (code 60)): expected a valid value (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (byte[])"<html>
<head><title>405 Not Allowed</title></head>
<body>
<center><h1>405 Not Allowed</h1></center>
<hr><center>nginx/1.21.6</center>
</body>
</html>
"; line: 1, column: 2]

Obviously the error is coming from one of the configured upstreams but I don't know which one just by looking at the logs.

I can figure it out with some testing but it would be nice if the ResponseParser could tell us which one is throwing the error. Based on the output of the "State of ETH" messages I think it's reporting the upstream at 0 in this case.
@splix
Copy link
Member

splix commented Oct 4, 2022

Good point. Will add it.

Previous it wasn't logged at all, so with the new version I've improved the handling and logging of upstream errors so now you can see them like this. And you're right, it definitely needs to specify the upstream id

@splix splix added this to the Version 0.14 milestone Oct 4, 2022
vdoflip pushed a commit to jit-strategies/dshackle that referenced this issue Aug 1, 2023
@a10zn8
Clients stream should be sequentially concated (emeraldpay#187)
8a2455f 
* Clients stream should be sequentially concated
* remove debug log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.14
Development

No branches or pull requests
2 participants
@splix @MysticRyuujin