Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically show output panel #105

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

oNaiPs
Copy link
Contributor

@oNaiPs oNaiPs commented Oct 6, 2024

Implements spec from #104.

Allows user to specify, per command, wether they want to show the output panel or not.

Adds the following new setting:

- ...
- `commands`
  - `autoShowOutputPanel` - Automatically shows the output panel:
    - `never` - Never changes the output panel visibility (default).
    - `always` - Shows output panel when the first command starts.
    - `error` - Shows output panel when a command fails.
    - ...

Example usage on vscode settings.json:

  "emeraldwalk.runonsave": {
    "commands": [
      {
        "cmd": "pwd",
        "autoShowOutputPanel": "always"
      }
    ]
  }

@oNaiPs oNaiPs force-pushed the automatically_show_output_panel branch 4 times, most recently from da8da68 to e8e3e7b Compare October 6, 2024 09:19
README.md Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
Copy link
Member

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I think we need to get rid of the auto-hide feature (see inline comment) and update docs accordingly.

Also, I know I don't have any instructions on PR format yet, but it would be good to have an example settings in the PR description that I can test the functionality with.

@oNaiPs oNaiPs force-pushed the automatically_show_output_panel branch 3 times, most recently from f1545cd to 9323f5c Compare October 10, 2024 05:56
@oNaiPs oNaiPs force-pushed the automatically_show_output_panel branch from 9323f5c to fba42ac Compare October 10, 2024 05:57
@oNaiPs
Copy link
Contributor Author

oNaiPs commented Oct 10, 2024

@bmingles should be done now, let me know if that works.

Copy link
Member

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@bmingles bmingles merged commit 3d056b9 into emeraldwalk:main Oct 12, 2024
@bmingles
Copy link
Member

@oNaiPs Your change should be available in the 0.3.2 pre-release:
https://github.com/emeraldwalk/vscode-runonsave/releases/tag/v0.3.2-pre

@oNaiPs oNaiPs deleted the automatically_show_output_panel branch October 17, 2024 11:23
@bmingles bmingles linked an issue Oct 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically show output panel
2 participants