-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically show output panel #105
Automatically show output panel #105
Conversation
da8da68
to
e8e3e7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I think we need to get rid of the auto-hide feature (see inline comment) and update docs accordingly.
Also, I know I don't have any instructions on PR format yet, but it would be good to have an example settings in the PR description that I can test the functionality with.
f1545cd
to
9323f5c
Compare
9323f5c
to
fba42ac
Compare
@bmingles should be done now, let me know if that works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR.
@oNaiPs Your change should be available in the 0.3.2 pre-release: |
Implements spec from #104.
Allows user to specify, per command, wether they want to show the output panel or not.
Adds the following new setting:
Example usage on vscode
settings.json
: