Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan9 support #397

Closed
foxcpp opened this issue Oct 22, 2020 · 6 comments · Fixed by #398
Closed

Plan9 support #397

foxcpp opened this issue Oct 22, 2020 · 6 comments · Fixed by #398
Labels
bug client

Comments

@foxcpp
Copy link
Collaborator

foxcpp commented Oct 22, 2020 •
edited
Loading

Apparently syscall.ECONNRESET is undefined when building with GOOS=plan9.
This causes compilation to fail here:

go-imap/client/client.go

Line 157 in c8e5db3

if syscallErr.Err == syscall.ECONNRESET {

Context: We got somebody trying to run foxcpp/maddy on Plan9. Client package is imported indirectly via go-imap-compress:

⟩ go mod why github.com/emersion/go-imap/client
# github.com/emersion/go-imap/client
github.com/foxcpp/maddy/internal/endpoint/imap
github.com/emersion/go-imap-compress
github.com/emersion/go-imap/client
@foxcpp
Copy link
Collaborator Author

foxcpp commented Oct 22, 2020

6028838 added problematic code.

@foxcpp
Copy link
Collaborator Author

foxcpp commented Oct 22, 2020

CC @Neopallium

@emersion
Copy link
Owner

emersion commented Oct 22, 2020 •
edited
Loading

8001f1c and #225 (comment) are relevant.

foxcpp added a commit to foxcpp/go-imap that referenced this issue Oct 22, 2020
@foxcpp
client: Drop syscall.ECONNRESET hack from Client.readOnce
60073a6 
Closes emersion#397
@foxcpp foxcpp mentioned this issue Oct 22, 2020
Merged
emersion pushed a commit that referenced this issue Oct 22, 2020
@foxcpp @emersion
client: Drop syscall.ECONNRESET hack from Client.readOnce
f9d60f8 
Closes #397
@Neopallium
Copy link

I don't remember how I was able to cause that error to happen.

@emersion
Copy link
Owner

IIRC those appeared when running the tests: #399

@Neopallium
Copy link

Ah. Yes. The hack was to consume the connection reset error and turn it into a EOF condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: Drop syscall.ECONNRESET hack from Client.readOnce foxcpp/go-imap
3 participants
@Neopallium @emersion @foxcpp