This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Feat/allow shell glob patterns #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
Jun 30, 2021
| Output profiles can contain shell glob patterns: | ||
| ``` | ||
| { | ||
|
|
There was a problem hiding this comment.
You have an extra line here.
| @@ -45,6 +46,15 @@ enabled if all of the listed outputs are connected. | |||
| } | |||
| ``` | |||
|
|
|||
| Output profiles can contain shell glob patterns: | |||
There was a problem hiding this comment.
And missing one line here.
Comment on lines
-24
to
+25
| (strchr(output->name, ' ') != NULL && | ||
| strstr(head->description, output->name) != NULL); | ||
| fnmatch(output->name, head->description, 0) == 0; |
There was a problem hiding this comment.
Aren't you removing the substring match functionality here? Is it intentional?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #72