add support for [\n] character format parameter inside config file #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascent12
reviewed
Sep 6, 2018
types.c
Outdated
| char ch; | ||
| while ((ch = *location++) != '\0') { | ||
| switch (state) { | ||
| case MAKO_PARSE_STATE_ESCAPE: |
There was a problem hiding this comment.
I think the style is to not indent case labels.
types.c
Outdated
| @@ -123,3 +124,55 @@ bool parse_directional(const char *string, struct mako_directional *out) { | |||
| free(components); | |||
| return true; | |||
| } | |||
|
|
|||
| bool parse_format(const char *string, char **out) { | |||
| int token_max_length = strlen(string) + 1; | |||
types.c
Outdated
| const char *location = string; | ||
|
|
||
| char ch; | ||
| while ((ch = *location++) != '\0') { |
There was a problem hiding this comment.
I think a normal for loop would be better.
|
Thanks for your PR! I agree with @ascent12's comments (thanks!).
I'm not super-concerned about this. Maybe keeping unknown escaped sequences as-is would be a little bit better. |
emersion
approved these changes
Sep 23, 2018
|
Thanks! |
|
sorry, i should have pinged you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #61
As a consequence also the char
\needs to be escaped.i'll update the
mako.1.sdcfile once the modification are approved