Job control improvements #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 14, 2020 12:04
caseman
commented
Nov 14, 2020
| @@ -226,7 +226,11 @@ static bool _job_wait(struct mrsh_state *state, pid_t pid, int options) { | |||
| // shell. Child processes want to block until their own children have | |||
| // terminated. | |||
| if (!priv->child) { | |||
| #ifdef WCONTINUED | |||
There was a problem hiding this comment.
Without this the Archlinux build fails which is interesting since this was introduced in Linux afaik. It could be because of the build options though if they are excluding this somehow by specifying an older standard.
|
Superceded by: #176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft fix for #174
run_command_list_arrayfor background jobs so that actual child state can be tracked properlyI included a jobs.sh test script, but it isn't incorporated into the test target because it causes it hang. Running it separately it works fine though and exits cleanly. Also not sure if these tests are only for parity, if so then it needs more attention since I didn't attempt to run it in other shells yet.
See also XXX comments inline. In particular the one about the general fork abstraction. I feel like forking a job process could be generalized since it happens in several places.