Add support for Nashorn & Node.js repls. #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code for all three "embedded" REPLs is now in a single namespace. This required upgrading the Clojure and ClojureScript versions used for development and testing, which also required upgrading Midje and lein-midje. Test updates are included, though I could not get the tests to run properly in the `plugin` project - I am not sure how they *could* run given the current state of the code. Midje seems to bail early instead of acknowledging an expected error. Tests in `support` pass correctly.
|
I want this to be merged!! |
|
@crocket this kind of comment comes across as unhelpful. Everybody working or contributing on cljsbuild (and most open source projects) are doing it as a gift for the community. If you're interested in seeing it merged, then a polite 👍 would probably suffice. Open source burnout is a real thing, and these kinds of comments contribute to it. |
|
@levand Happy to merge this. I don't mind doing a manual merge to resolve the conflicts, or would you want to resolve the conflicts yourself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for all three "embedded" REPLs is now in a single namespace.
This required upgrading the Clojure and ClojureScript versions used for
development and testing, which also required upgrading Midje and
lein-midje.
Test updates are included, though I could not get the tests to run
properly in the
pluginproject - I am not sure how they could rungiven the current state of the code. Midje seems to bail early instead
of acknowledging an expected error. Tests in
supportpass correctly.Documentation is also included