Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emibcn/badge-action@v1.2.4 gets warning about using old @actions/core #18

Closed
DavidCooperWCU opened this issue Oct 21, 2022 · 4 comments
Closed
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@DavidCooperWCU
Copy link

DavidCooperWCU commented Oct 21, 2022

The following warning happens when using the badge action:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.  
For more information see:   
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This can be fixed by updating the version of @actions/core

@emibcn emibcn added bug Something isn't working good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Oct 21, 2022
rmhrazorhead added a commit to rmhrazorhead/badge-action that referenced this issue Oct 27, 2022
Should resolve issue 18
emibcn#18
@ben-manes
Copy link

Just in case anyone is waiting on this and the author doesn't get to releasing a fix, I replaced a simple usage with badgen.net.

-uses: emibcn/badge-action@d6f51ff11b5c3382b3b88689ae2d6db22d9737d1
-with:
-  label: tests
-  color: 31c653
-  path: badge.svg
-  status: ${{ fromJSON(steps.test-results.outputs.json).formatted.stats.runs }}
+env:
+  LABEL: tests
+  COLOR: 31c653
+  STATUS: ${{ fromJSON(steps.test-results.outputs.json).formatted.stats.runs }}
+run: curl -s https://badgen.net/badge/${{env.LABEL}}/${{env.STATUS}}/${{env.COLOR}} > badge.svg

@emibcn
Copy link
Owner

emibcn commented Nov 8, 2022

Hi @ben-manes ,
If you want to make a PR, I'll really appreciate it.

@emibcn
Copy link
Owner

emibcn commented Nov 8, 2022

There's an ongoing PR in #20

emibcn added a commit to emibcn/github-badge-action that referenced this issue Dec 9, 2022
emibcn added a commit that referenced this issue Dec 9, 2022
emibcn added a commit that referenced this issue Dec 9, 2022
emibcn added a commit that referenced this issue Dec 9, 2022
@emibcn
Copy link
Owner

emibcn commented Dec 9, 2022

Working workflow without deprecation warnings:
https://github.com/emibcn/github-badge-action/actions/runs/3658127464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants