Request.SelectedRoutePath panics if no route is selected #467
Comments
axw
added a commit
to axw/apm-agent-go
that referenced
this issue
Apr 12, 2021
Pin to an older version of go-restful, to work around emicklei/go-restful#467
axw
added a commit
to elastic/apm-agent-go
that referenced
this issue
Apr 12, 2021
* scripts: pin go-restful to v3.4.0 Pin to an older version of go-restful, to work around emicklei/go-restful#467 * Pin to v2.9.6 instead To cater for Go 1.8, pin to v2.9.6 instead. We'll continue to test newer versions with versions of Go that support modules.
|
thank you for reporting this. somehow the tests did not capture this. will work on a fix asap |
emicklei
added a commit
that referenced
this issue
Apr 12, 2021
stuartnelson3
pushed a commit
to elastic/apm-agent-go
that referenced
this issue
Jul 30, 2021
* scripts: pin go-restful to v3.4.0 Pin to an older version of go-restful, to work around emicklei/go-restful#467 * Pin to v2.9.6 instead To cater for Go 1.8, pin to v2.9.6 instead. We'll continue to test newer versions with versions of Go that support modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Request.SelectedRoutePathpanics when called on a request with selected route. For example, this happens when using Elastic APM'sapmrestfulfilter: https://github.com/elastic/apm-agent-go/blob/f62afdfda01d0cbe73f477c357d5b8a3017e5144/module/apmrestful/filter.go#L55-L66This is caused by https://github.com/emicklei/go-restful/pull/462/files. Previously the method would return "".
The text was updated successfully, but these errors were encountered: