Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options shortcut #455

Merged
merged 2 commits into from
Nov 10, 2020
Merged

add options shortcut #455

merged 2 commits into from
Nov 10, 2020

Conversation

RobinTsai
Copy link
Contributor

@RobinTsai RobinTsai commented Oct 30, 2020

add OPTIONS shortcut WebService receiver

#454

@codecov-io
Copy link

Codecov Report

Merging #455 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   71.30%   71.25%   -0.06%     
==========================================
  Files          25       25              
  Lines        1199     1200       +1     
==========================================
  Hits          855      855              
- Misses        274      275       +1     
  Partials       70       70              
Impacted Files Coverage Δ
web_service.go 67.85% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601692b...a7a747c. Read the comment docs.

@RobinTsai RobinTsai marked this pull request as ready for review November 1, 2020 14:59
@RobinTsai
Copy link
Contributor Author

@emicklei There is the PR for #454 .

I reviewed the test file, and seems there isn't any proper test case to be added. Any suggestion?

image

@RobinTsai
Copy link
Contributor Author

Added test.

@RobinTsai
Copy link
Contributor Author

@emicklei Hey buddy, how is it going

@emicklei emicklei merged commit e5d3175 into emicklei:master Nov 10, 2020
emicklei pushed a commit that referenced this pull request Nov 10, 2020
* add options shortcut

* add test for options shortcut
@RobinTsai RobinTsai deleted the add-websrv-options branch November 11, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants