Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug assert when opening context menus #4113

Closed
emilk opened this issue Feb 29, 2024 · 0 comments · Fixed by #4114
Closed

debug assert when opening context menus #4113

emilk opened this issue Feb 29, 2024 · 0 comments · Fixed by #4114
Assignees
@emilk
Labels
bug Something is broken crash crash, panic, segfault, freeze, …
Milestone
Next Major Release

Comments

@emilk
Copy link
Owner

emilk commented Feb 29, 2024

Only affects master.

Open a context-menu with a right-click in a debug build and you'll hit

'Widget changed layer_id during the frame', crates/egui/src/widget_rect.rs:114:17
@emilk emilk added bug Something is broken crash crash, panic, segfault, freeze, … labels Feb 29, 2024
@emilk emilk self-assigned this Feb 29, 2024
@emilk emilk added this to the Next Major Release milestone Feb 29, 2024
@emilk emilk mentioned this issue Feb 29, 2024
Merged
emilk added a commit that referenced this issue Feb 29, 2024
@emilk
Give each menu Area an id distinct from the id of what was clicked (#…
86d7f29 
…4114)

* Closes #4113

Previously the `Id` of the menu `Area` was using the same id as the
thing that was clicked (i.e. the button opening menu), which lead to id
clashes
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@emilk @hacknus
Give each menu Area an id distinct from the id of what was clicked (e…
9083b65 
…milk#4114)

* Closes emilk#4113

Previously the `Id` of the menu `Area` was using the same id as the
thing that was clicked (i.e. the button opening menu), which lead to id
clashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
bug Something is broken crash crash, panic, segfault, freeze, …
Projects
None yet
Milestone
Next Major Release
Development

Successfully merging a pull request may close this issue.

Give each menu Area an id distinct from the id of what was clicked emilk/egui
1 participant
@emilk