Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + scroll wheel zoom no longer works (v0.28) #4777

Closed
Barugon opened this issue Jul 4, 2024 · 1 comment · Fixed by #4778
Closed

Ctrl + scroll wheel zoom no longer works (v0.28) #4777

Barugon opened this issue Jul 4, 2024 · 1 comment · Fixed by #4778
Labels
bug Something is broken

Comments

@Barugon
Copy link
Contributor

Barugon commented Jul 4, 2024

Describe the bug
Event::Zoom is now never sent via Context::input for ctrl + scroll wheel.

To Reproduce
Steps to reproduce the behavior:

  1. Implement Context:input and specifically look for Event::Zoom
  2. Execute the app, hold the control key and spin the mouse-wheel
  3. Note that Event::Zoom is never received

Desktop (please complete the following information):

  • OS: Fedora
  • Version: 40
@Barugon Barugon added the bug Something is broken label Jul 4, 2024
@emilk
Copy link
Owner

emilk commented Jul 4, 2024

This is actually expected behavior, though I forgot to mention it in the 0.28 migration guide (will fix!).

In #4524 I changed the behavior of ctrl-scroll to no longer emit Zoom events in the integration. Instead zooming is handled in egui:

let is_zoom = modifiers.ctrl || modifiers.mac_cmd || modifiers.command;

As a user, you should use InputState::smooth_scroll_delta or InputState::raw_scroll_delta.

emilk added a commit that referenced this issue Jul 4, 2024
* Closes #4777

Also add this to the 0.28 migration guide.
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
* Closes emilk#4777

Also add this to the 0.28 migration guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants