Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive RunMode broken on Windows 10 #755

Closed
parasyte opened this issue Sep 29, 2021 · 2 comments · Fixed by #756
Closed

Reactive RunMode broken on Windows 10 #755

parasyte opened this issue Sep 29, 2021 · 2 comments · Fixed by #756
Labels
bug Something is broken

Comments

@parasyte
Copy link
Contributor

This was reported in #21 (comment)

git bisect shows that 04b3921 caused the regression. (Looks like my guess was right!)

To Reproduce
Steps to reproduce the behavior:

  1. Run egui_demo_app on Windows 10
  2. Open the Backend panel.
  3. Set "Mode" to Reactive

Expected behavior
With the Backend panel open, the "Total frames painted" counter should not be updated until an event is produced. E.g. by moving the mouse.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: master
@parasyte parasyte added the bug Something is broken label Sep 29, 2021
@parasyte
Copy link
Contributor Author

FWIW, rfd has async file dialogs that work correctly with the current winit event loop. This has been discussed in multiple places, including rust-windowing/winit#1779 and EmbarkStudios/nfd2#11

@emilk
Copy link
Owner

emilk commented Sep 29, 2021

Yeah, it is looking more and more like we should revert 04b3921

I'd still love for non-async dialogs to work as well.

I'll take a look at the winit fix provided by @PolyMeilex at https://github.com/PolyMeilex/winit (and ported to winit 0.25 by @vihdzp at https://github.com/OfficialURL/winit)

emilk added a commit that referenced this issue Sep 29, 2021
emilk added a commit that referenced this issue Sep 30, 2021
* Revert change to winit event loop in egui_glium

This reverts #631

Fixes #755

* Add example of file dialogs and file drag-and-drop

* fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants