Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make color_picker_hsva_2d public. #1091

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Conversation

HackerFoo
Copy link
Contributor

Exposes color_picker_hsva_2d, so the color picker can be shown without an egui button. A similar public function exists, but it converts the color to Color32.

I use this to show the color picker on top of a custom UI.

Screen Shot 2022-01-10 at 11 24 20

@BctfN0HUK7Yg
Copy link
Contributor

This color picker isn't universal. Better way is to make you own widget for this by copying and tuning original code

@HackerFoo
Copy link
Contributor Author

HackerFoo commented Jan 10, 2022

The color picker is useful to me without any further tuning, and the Color32 version is already public. I could use that if necessary, but I don't need the conversion to Color32, and this function was already written, just not public.

egui/src/widgets/color_picker.rs Outdated Show resolved Hide resolved
egui/src/widgets/color_picker.rs Outdated Show resolved Hide resolved
HackerFoo and others added 2 commits January 18, 2022 10:17
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@emilk emilk merged commit e4aa1e6 into emilk:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants