Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Very happy to make my first contribution here!
This adds boxed zooming feature on plots.
demo: https://www.youtube.com/watch?v=oUSWUgdFBCs
To allow the feature to work I added:
Plot::allow_boxed_zoom(bool)
. Defaulttrue
Plot::boxed_zoom_pointer(PointerButton)
. Default:Secondary
PlotMemory::last_click_pos_for_zoom: Option<Pos2>
, DefaultNone
ScreenTransform::bounds_mut(&mut self) -> &mut PlotBounds
Also changelog has been updated, check.sh is passing. And next time I will make sure to create an issue first.
I had a little non related issue in check.sh so double check for me please.
Regards,