Allow scroll into view without specifying an alignment #1247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
response.scroll_to_me
works great. However, in some cases, you only want to bring a UI into view if it's not visible, and don't do anything if it's already visible.Solution
Accept an
Option<Align>
instead of justAlign
. IfNone
is passed, the minimum scrolling necessary to fully bring the ui into view will be applied.🎥
Peek.2022-02-13.09-49.mp4