Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sliders correctly generate events on change. #1854

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

ndarilek
Copy link
Contributor

It doesn't appear as if change events are correctly generated when sliders update. This at least generates the events, though I'm a bit unclear on how keyboard-handling is intended to work with these.

@ndarilek
Copy link
Contributor Author

Not sure this failure is my fault--looks like wasm-bindgen may need to be pinned in the job definition.

@emilk emilk merged commit 0913c77 into emilk:master Jul 25, 2022
@emilk
Copy link
Owner

emilk commented Jul 25, 2022

Not sure this failure is my fault--looks like wasm-bindgen may need to be pinned in the job definition.

Correct you are! Fixing in #1855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants