Add option to disable mouse dragging on scroll area. #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This reverts commit 4990e61.
mkrueger
reviewed
Dec 5, 2022
| @@ -608,7 +629,7 @@ impl Prepared { | |||
|
|
|||
| if content_is_too_large[0] || content_is_too_large[1] { | |||
| // Drag contents to scroll (for touch screens mostly): | |||
| let sense = if self.scrolling_enabled { | |||
| let sense = if self.drag_to_scroll_enabled { | |||
There was a problem hiding this comment.
Shouldn't it check both flags ?
let sense = if self.scrolling_enabled && self.drag_to_scroll_enabled {
|
I can really, really need that. Thanks. |
emilk
reviewed
Jan 7, 2024
| @@ -90,6 +90,8 @@ pub struct ScrollArea { | |||
| offset_y: Option<f32>, | |||
| /// If false, we ignore scroll events. | |||
| scrolling_enabled: bool, | |||
| /// If false we ignore mouse drag events. | |||
| drag_to_scroll_enabled: bool, | |||
There was a problem hiding this comment.
When would you want to turn this off for just one ScrollArea an not another?
Wouldn't it make more sense to put this as global setting in Style instead?
emilk
reviewed
Jan 7, 2024
| @@ -521,6 +541,7 @@ impl Prepared { | |||
| content_ui, | |||
| viewport: _, | |||
| scrolling_enabled, | |||
| drag_to_scroll_enabled: mouse_dragging_enabled, | |||
There was a problem hiding this comment.
Suggested change
| drag_to_scroll_enabled: mouse_dragging_enabled, | |
| drag_to_scroll_enabled, |
emilk
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Try out the cursor in any other application and try to follow that behavior.
- While typing, there shouldn't be blinking
- When stopping to type, there should be a short delay before the blinking starts
- The on-period and off-period should be equally long
A badly implemented cursor blinking is more annoying than useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option in scrollarea to disable dragging with the mouse seperatley from the option to disable scrolling entirely.
There is not much more to this commit and i am unsure if it is a trivial change.