Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_web.sh: fix script #25

Merged
merged 1 commit into from
Oct 1, 2020
Merged

build_web.sh: fix script #25

merged 1 commit into from
Oct 1, 2020

Conversation

yjh0502
Copy link
Contributor

@yjh0502 yjh0502 commented Oct 1, 2020

It looks build_web.sh is not working as intended, so here's a fix.

emilk
emilk approved these changes Oct 1, 2020
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Both versions work for me, so if only the latter works for you, let's go for it! I'm not a bash expert, so can't really tell why one would chose one over the other.

@emilk emilk merged commit b9cb3c7 into emilk:master Oct 1, 2020
@ambihelical ambihelical mentioned this pull request Apr 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjh0502 @emilk