Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed texture loading #3297
Managed texture loading #3297
Changes from all commits
f8cd5f4
aad9978
a94b17f
ec79d88
1934fba
5b113d5
c1443b9
f6efd05
652432a
015dc84
80dd53c
eceeda8
022d5a0
6819ea3
d954175
9ae51a2
aea252d
c2ecc34
52f3529
08951f1
41b074c
6b0a653
3fc03c3
78f2d93
4080b8f
2584fa8
3182c9d
ae0c6c1
4cfec50
a10a88c
a8ae600
08cb30b
2c8be3c
808e249
1d9a7ed
d109db4
9544b02
3f194cc
2962067
0dbaef0
f6104b9
1bfd26e
2a687b7
817b956
b733a58
1aacf42
356d7ef
0d28132
afa3ef3
a3c890d
f975d83
98ddf02
2736cb5
ef71ea2
76b5e74
30f0e0f
c84e9ab
d21e74e
59cd614
4206355
f0e9733
049122f
c8a8074
ef7e946
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We should consider how we can alert the user of methods that aren't immediate safe, most notably the old
Context::load_texture
. Adding a⚠️ Not immediate-mode safe
warning to them might be a start, but perhaps we could also add it to their name somehow.load_texture_sync
or something.