Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eframe: update the maximized/minimized viewport state each frame #3601

Merged
merged 1 commit into from
Nov 21, 2023
Merged

eframe: update the maximized/minimized viewport state each frame #3601

merged 1 commit into from
Nov 21, 2023

Conversation

emilk
Copy link
Owner

@emilk emilk commented Nov 21, 2023

This makes sure it is always up-to-date.

Previously (years back) this caused a deadlock on Mac, but this seems to have been fixed

@emilk emilk mentioned this pull request Nov 21, 2023
Open
@emilk emilk added the eframe Relates to epi and eframe label Nov 21, 2023
@emilk emilk merged commit e037489 into master Nov 21, 2023
35 of 36 checks passed
@emilk emilk deleted the emilk/fix-minimized-maximized branch November 21, 2023 18:05
emilk added a commit that referenced this pull request Nov 23, 2023
@emilk
Revert e037489 / #3601
b20ae7c 
* Reopens #3494

It caused a deadlock on Mac when running `custom_window_frame`
@emilk emilk mentioned this pull request Nov 23, 2023
Merged
emilk added a commit that referenced this pull request Nov 23, 2023
@emilk
Fix deadlock on custom_window_frame (#3612)
85489dc 
* Reverts commit e037489 (#3601)
* Reopens #3494

It caused a deadlock on Mac when running `custom_window_frame`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
eframe Relates to epi and eframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect maximize behaviour
1 participant
@emilk