Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox: fix justified layout of popup if wider than parent button #4570

Merged
merged 1 commit into from
May 29, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented May 29, 2024

The ComboBox popup has a justified layout to make selection of items easier.

Thanks to the new sizing pass logic we don't have to know the final width in advance:

image

@emilk emilk added the egui label May 29, 2024
@emilk emilk merged commit ffbc63e into master May 29, 2024
36 checks passed
@emilk emilk deleted the emilk/improve-combo-box-width branch May 29, 2024 09:47
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
…emilk#4570)

* Closes emilk#4452

The `ComboBox` popup has a justified layout to make selection of items
easier.

Thanks to [the new sizing pass
logic](emilk#4535) we don't have to know
the final width in advance:


![image](https://github.com/emilk/egui/assets/1148717/53b0dda7-14c9-43be-a073-ad49865e69a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComboBox menu doesn't report its actual size to its closure
1 participant