Function : Returns the FontId corresponding to the given TextStyle
#4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bircni
reviewed
Aug 2, 2024
crates/egui/src/ui.rs
Outdated
| @@ -544,6 +544,11 @@ impl Ui { | |||
| self.painter().layer_id() | |||
| } | |||
|
|
|||
| /// Returns the `FontId` corresponding to the given `TextStyle`. | |||
| pub fn font_id_by_text_style(&self, style: &TextStyle) -> FontId { | |||
There was a problem hiding this comment.
I would suggest to call it font_id() or text_style_font_id this would match with text_style_height
There was a problem hiding this comment.
thank you.
Both font_id() and text_style_font_id() looks good.
I'll have to wait for emilk's opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function : Returns the
FontIdcorresponding to the givenTextStyleBefore : hard
After : easy
I'm not sure what would be a good name for the function.