Update all examples, all tests, and egui_demo_app to use env_logger 0.11
#4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bircni
approved these changes
Aug 12, 2024
|
@bircni Thanks! I'm on windows so I couldn't run that shell script - which is why I pointed to the Github Action run, because I was pretty sure it'd run |
|
The script is for Linux only 😊 |
emilk
reviewed
Aug 26, 2024
| version = "0.2.2" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "06abde3611657adf66d383f00b093d7faecc7fa57071cce2578660c9f1010821" | ||
|
|
There was a problem hiding this comment.
This adds a lot of dependencies - is there a way to avoid them with feature-flags on env_logger, or by using an alternative crate?
There was a problem hiding this comment.
I don't think so.
That said, these extra dependencies are only compiled alongside examples and tests - not alongside egui itself. Thus, I doubt they'll be much of an issue, unless you're constantly running cargo clean.
|
Is there anything blocking this from being merged? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all examples, all tests, and the
egui_demo_appcrate to use the latest version of env_logger,0.11. This helps to clean up the list of outdated crates listed when runningcargo outdated --root-deps-only --workspace.To ensure I didn't break anything, I ran
cargo build --all-features --all-targets(and the same withcargo test), and saw nothing that made me feel that I broke anything. Additionally, the CI run for my commit finished successfully: https://github.com/LikeLakers2/egui/actions/runs/10347887485Before making this PR, I did take notice of a similar PR, #4164, but because it's a 5-month-old draft that appears to be abandoned, I decided to make this PR.