Fix: Ui::new_child does not consider the sizing_pass field of UiBuilder
#5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5262-fix-layout-sizing-pass |
lucasmerlin
approved these changes
Oct 14, 2024
lucasmerlin
changed the title
UiBuilderUi::new_child does not consider the sizing_pass field of UiBuilder
|
Good catch! |
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…ilder` (emilk#5262) During the sizing pass we want widgets to use up as little space as possible, but it does not consider the sizing_pass field of `UiBuilder`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the sizing pass we want widgets to use up as little space as possible, but it does not consider the sizing_pass field of
UiBuilder.